Build: Use jsHint extends option #1471

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Member

mgol commented Dec 27, 2013

jsHint 2.4.0 adds an option to extend another configuration file,
making it possible to extract common configuration to a separate file.

Note: I'm not happy with the assign hack so it might be better to wait until jshint/jshint#1439 is fixed. Nonetheless, I wanted to get some feedback so I'm putting it here.

Fixing jshint/jshint#1439 will let us not only not add the hack I had to add here but also remove the one with deleting the onevar option - it's better to just overwrite it in dist/.jshintrc. All our jsHint configuration can then be merged to one target instead of two we have now.

@timmywil timmywil and 1 other commented on an outdated diff Dec 27, 2013

@@ -39,7 +44,7 @@ module.exports = function( grunt ) {
],
// Exclude specified modules if the module matching the key is removed
removeWith: {
- ajax: [ "manipulation/_evalUrl" ],
+ ajax: [ "manipulationhintrc/_evalUrl" ],
@timmywil

timmywil Dec 27, 2013

Owner

This must be a typo.

@mgol

mgol Dec 27, 2013

Member

Thx, corrected.

Owner

timmywil commented Dec 27, 2013

I vote for waiting until the issue is fixed so we don't need to add assign.

Member

mgol commented Dec 27, 2013

@timmywil I agree with you, I just wanted to have the rest reviewed and then wait for the fix.

Member

mgol commented Jan 26, 2014

Updated to newest jsHint, no need for lodash.assign anymore.

Also, the srcHintOptions hack was removed in favor of an explicit dist/.jshintrc file that just extends the common one.

@mgol mgol Build: Use jsHint extends option
jsHint 2.4.0 adds an option to extend another configuration file,
making it possible to extract common configuration to a separate file.
ba45041
Owner

dmethvin commented Mar 14, 2014

@mzgol Do you want to freshen this up and land it?

Member

mgol commented Mar 18, 2014

Still no support in Jetbrains IDEs. It may be better to wait with this a little longer, closing for now.

mgol closed this Mar 18, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment