Manipulation: Use textarea for missing IE defaultValue check (#14716) #1495

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@dmethvin
Member

dmethvin commented Jan 22, 2014

IE11 fixed the checkbox defaultValue issue but not textarea. Rather than
creating a new detect name I'm reusing the old one to protect anyone who
is unwisely using this externally. Re-fixing the defaultValue of when it
doesn't need to be done is not a problem, so leave that code for IE11.

Fixes #14716

@mgol

This comment has been minimized.

Show comment Hide comment
@mgol

mgol Jan 22, 2014

Member

@dmethvin You also need to update IE11 value for this check in test/unit/support.js

Member

mgol commented Jan 22, 2014

@dmethvin You also need to update IE11 value for this check in test/unit/support.js

- input.checked = true;
- support.noCloneChecked = input.cloneNode( true ).checked;
+ // Make sure textarea (and checkbox) defaultValue is properly cloned
+ // Support: IE9-IE11+

This comment has been minimized.

Show comment Hide comment
@mgol

mgol Jan 22, 2014

Member

I like this comment. :) If we automatically added + to the version unless we tested it's fixed in a newer one, we'd be done guessing our support comments.

@mgol

mgol Jan 22, 2014

Member

I like this comment. :) If we automatically added + to the version unless we tested it's fixed in a newer one, we'd be done guessing our support comments.

This comment has been minimized.

Show comment Hide comment
@dmethvin

dmethvin Jan 22, 2014

Member

I think someone suggested it somewhere, so the last version is the last one we definitively know is broken.

@dmethvin

dmethvin Jan 22, 2014

Member

I think someone suggested it somewhere, so the last version is the last one we definitively know is broken.

Manipulation: Use textarea for missing IE defaultValue check
IE11 fixed the checkbox defaultValue issue but not textarea. Rather than
creating a new detect name I'm reusing the old one to protect anyone who
is unwisely using this externally. Re-fixing the defaultValue of when it
doesn't need to be done is not a problem, so leave that code for IE11.

Fixes #14716

@dmethvin dmethvin closed this in a204942 Jan 23, 2014

dmethvin added a commit that referenced this pull request Jan 23, 2014

Manipulation: Use textarea for missing IE defaultValue check
IE11 fixed the checkbox defaultValue issue but not textarea. Rather than
creating a new detect name I'm reusing the old one to protect anyone who
is unwisely using this externally. Re-fixing the defaultValue when it
doesn't need to be done is not a problem, so leave that code for IE11.

Fixes #14716
Closes gh-1495

mescoda pushed a commit to mescoda/jquery that referenced this pull request Nov 4, 2014

Manipulation: Use textarea for missing IE defaultValue check
IE11 fixed the checkbox defaultValue issue but not textarea. Rather than
creating a new detect name I'm reusing the old one to protect anyone who
is unwisely using this externally. Re-fixing the defaultValue when it
doesn't need to be done is not a problem, so leave that code for IE11.

Fixes #14716
Closes gh-1495

@dmethvin dmethvin deleted the dmethvin:14716-clone-textarea branch Nov 5, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment