Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

window.getDefaultComputedStyle may return null #1501

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Contributor

rosenfeld commented Jan 28, 2014

In Iceweasel 24.2.0 it happens here when I call layout from jQuery layout plugin in an iframe from an invisible tab (from jQuery UI tabs).

I know it's not in the API specification but believe me: it may return null. Here's the message I get in the console of Iceweasel 24.2.0:

"TypeError: window.getDefaultComputedStyle(...) is null"

@rosenfeld rosenfeld window.getDefaultComputedStyle may return null
In Iceweasel 24.2.0 it happens here when I call layout from jQuery layout plugin in an iframe from an invisible tab (from jQuery UI tabs).
ab632f8
Owner

dmethvin commented Feb 7, 2014

I'm thinking we may not want getDefaultComputedStyle at all, we'll discuss in our meeting next week.

Contributor

rosenfeld commented Feb 7, 2014

I agree

@dmethvin dmethvin added this to the 1.11.1/2.1.1 milestone Mar 13, 2014

Owner

dmethvin commented Mar 13, 2014

We should either guard this for the .1 release or remove it.

Member

markelog commented Mar 13, 2014

remove it

+1

Owner

dmethvin commented Mar 14, 2014

For now let's just land this patch. Longer term we should decide whether to pull this since it seems like the standards groups aren't moving on getDefaultComputedStyle and only Firefox ever implemented it.

@dmethvin dmethvin closed this in e547a27 Mar 20, 2014

@dmethvin dmethvin added a commit that referenced this pull request Mar 20, 2014

@rosenfeld @dmethvin rosenfeld + dmethvin CSS: window.getDefaultComputedStyle may return null
Fixes #14736
Closes gh-1501
(cherry picked from commit 51910ba8a5aff4cd1a811f1fdb76a6c62a09a666)
5a1db91

@mescoda mescoda pushed a commit to mescoda/jquery that referenced this pull request Nov 4, 2014

@rosenfeld @dmethvin rosenfeld + dmethvin CSS: window.getDefaultComputedStyle may return null
Fixes #14736
Closes gh-1501
(cherry picked from commit 51910ba8a5aff4cd1a811f1fdb76a6c62a09a666)
c831621
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment