Skip to content

CSS: jQuery#hide should always save display value #1509

Closed
wants to merge 1 commit into from

5 participants

@markelog
jQuery Foundation member
markelog commented Feb 5, 2014

See 14750. It saves some bytes and it would slow it down a bit.

@mgol
jQuery Foundation member
mgol commented Feb 6, 2014

@markelog Per the discussion on the group, please add your surname to your git settings and amend this commit with the proper data.

@dmethvin
jQuery Foundation member
dmethvin commented Feb 7, 2014

Doesn't the existing .mailmap entry for Oleg take care of this?

@dmethvin dmethvin added this to the 1.11.1/2.1.1 milestone Feb 7, 2014
@mgol
jQuery Foundation member
mgol commented Feb 7, 2014

@dmethvin It should take care of past commits (& this one for that matter) but from what I understood the policy is to include the full name (or at least the first & last name) going forward.

cc @scottgonzalez

@scottgonzalez
jQuery Foundation member

It should take care of past commits (& this one for that matter) but from what I understood the policy is to include the full name (or at least the first & last name) going forward.

Correct. There is no reason to continue to store bad info just because the mailmap exists.

@gibson042
jQuery Foundation member

👍 LGTM

@dmethvin
jQuery Foundation member

LGTM too, let's get this into the .1 release

@dmethvin dmethvin closed this Mar 13, 2014
@dmethvin
jQuery Foundation member

and to do that i'll need to stop pushing the close button.

@dmethvin dmethvin reopened this Mar 13, 2014
@markelog markelog added a commit that closed this pull request Mar 21, 2014
@markelog markelog CSS: jQuery#hide should always save display value
Fixes #14750
Closes gh-1509
5a8f769
@markelog markelog closed this in 5a8f769 Mar 21, 2014
@markelog markelog added a commit that referenced this pull request Mar 21, 2014
@markelog markelog CSS: jQuery#hide should always save display value
Fixes #14750
Closes gh-1509
(cherry picked from commit 5a8f769)

Conflicts:
	src/css.js
6dcca6d
@mescoda mescoda pushed a commit to mescoda/jquery that referenced this pull request Nov 4, 2014
@markelog markelog CSS: jQuery#hide should always save display value
Fixes #14750
Closes gh-1509
(cherry picked from commit 5a8f769)

Conflicts:
	src/css.js
b09a875
@fhemberger fhemberger added a commit that referenced this pull request Dec 9, 2014
@markelog markelog CSS: jQuery#hide should always save display value
Fixes #14750
Closes gh-1509
4f5ae9c
@bperel bperel pushed a commit that referenced this pull request Jul 21, 2015
@markelog markelog CSS: jQuery#hide should always save display value
Fixes #14750
Closes gh-1509
b7350f2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.