Use Element.matches if available #1524

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@timmywil

This comment has been minimized.

Show comment Hide comment
@timmywil

timmywil Feb 21, 2014

Owner

I'm less concerned about our qSA wrapper (see my Sizzle comment). In fact, I don't think the qSA wrapper will work anymore after we land the performance improvements for the events module.

Owner

timmywil commented Feb 21, 2014

I'm less concerned about our qSA wrapper (see my Sizzle comment). In fact, I don't think the qSA wrapper will work anymore after we land the performance improvements for the events module.

@dmethvin dmethvin added this to the 1.12/2.2 milestone Mar 1, 2014

@dmethvin

This comment has been minimized.

Show comment Hide comment
@dmethvin

dmethvin Mar 1, 2014

Owner

We'll need to fix that! 😄 I'm fine with it not precompiling in those cases but it needs to work.

Owner

dmethvin commented Mar 1, 2014

We'll need to fix that! 😄 I'm fine with it not precompiling in those cases but it needs to work.

@foolip

This comment has been minimized.

Show comment Hide comment
@foolip

foolip Mar 2, 2014

Contributor

Is any action from me required on this issue?

Contributor

foolip commented Mar 2, 2014

Is any action from me required on this issue?

@dmethvin

This comment has been minimized.

Show comment Hide comment
@dmethvin

dmethvin Mar 3, 2014

Owner

@timmywil how do you want to handle the qSA wrapper issues here?

Owner

dmethvin commented Mar 3, 2014

@timmywil how do you want to handle the qSA wrapper issues here?

@timmywil

This comment has been minimized.

Show comment Hide comment
@timmywil

timmywil Mar 3, 2014

Owner

The issue with the qSA wrapper does not affect this pull request. This can land. I'll have to make adjustments in the events patch.

Owner

timmywil commented Mar 3, 2014

The issue with the qSA wrapper does not affect this pull request. This can land. I'll have to make adjustments in the events patch.

@dmethvin dmethvin closed this in 2c2c93c Mar 21, 2014

@dmethvin dmethvin modified the milestones: 1.11.1/2.1.1, 1.12/2.2 Mar 21, 2014

@foolip foolip deleted the foolip:matches-unprefixed branch Mar 21, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment