New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS: Re-allow setting shorthand properties in IE<9 #1527

Closed
wants to merge 1 commit into
base: 1.x-master
from

Conversation

Projects
None yet
3 participants
@gibson042
Member

gibson042 commented Mar 2, 2014

   raw     gz Sizes
284202  84383 dist/jquery.js
 96537  33455 dist/jquery.min.js

   raw     gz Compared to 1.x-master @ f361f0378b80f6141e79d906821f6964bcdfbfc4
  +123    +42 dist/jquery.js
    +7     +3 dist/jquery.min.js
@markelog

This comment has been minimized.

Member

markelog commented Mar 3, 2014

Don't forget to specify ticket number in the commit, it won't close the ticket, but it nice to have in the commit body

@@ -242,15 +242,18 @@ test("css(String, Object)", function() {
equal( ret, div, "Make sure setting undefined returns the original set." );
equal( div.css("display"), display, "Make sure that the display wasn't changed." );
// Test for Bug #5509

This comment has been minimized.

@markelog

This comment has been minimized.

@markelog

markelog Mar 3, 2014

Member

Oh, i see, you put this in the assertion

@gibson042

This comment has been minimized.

Member

gibson042 commented Mar 3, 2014

Don't forget to specify ticket number in the commit, it won't close the ticket, but it nice to have in the commit body

Thanks for catching that. Fixed.

@mgol

This comment has been minimized.

Member

mgol commented Mar 10, 2014

Let's hold off until I fix http://bugs.jquery.com/ticket/14394 by reverting the !important patch.

@gibson042

This comment has been minimized.

Member

gibson042 commented Mar 10, 2014

Closing in favor of a 24e5879-reverting fix, which should pull in the new tests from here and #1532.

@gibson042 gibson042 closed this Mar 10, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment