Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug #7417 .css('border-spacing') throws exception in IE8, inconsistent in Opera; +10 Unit tests #164

Closed
wants to merge 1 commit into from

Conversation

@rwaldron
Copy link
Member

rwaldron commented Jan 5, 2011

In addition to throwing exception in IE8; borderSpacing returns "NNpx" in opera by default, and "NNpx NNpx" in all others. This adds a cssHook to normalize

@rwaldron

This comment has been minimized.

Copy link
Member Author

rwaldron commented Jan 5, 2011

@csnover

This comment has been minimized.

Copy link

csnover commented on src/css.js in 72982c0 Jan 9, 2011

Empty setter isn’t necessary. jQuery knows what to do.

@csnover

This comment has been minimized.

Copy link
Member

csnover commented Jan 9, 2011

You may want to install the pre-commit hook at http://pastebin.com/qsKpMQqx.

*
* You have some suspicious patch lines:
*
* In src/css.js
* trailing whitespace (line 63)
src/css.js:63:      }       
* In test/unit/css.js
* trailing whitespace (line 331)
test/unit/css.js:331:  
* trailing whitespace (line 333)
test/unit/css.js:333:  
* trailing whitespace (line 337)
test/unit/css.js:337:  
* trailing whitespace (line 341)
test/unit/css.js:341:  
* trailing whitespace (line 349)
test/unit/css.js:349:  
* trailing whitespace (line 353)
test/unit/css.js:353:  
* trailing whitespace (line 356)
test/unit/css.js:356:  equals( jQuery('#tableborderspacing').css("border-spacing"), "2px 1px", "Setting border-spacing to `null` has no effect" );  
* trailing whitespace (line 360)
test/unit/css.js:360:  equals( jQuery('#tableborderspacing').css("border-spacing"), "2px 1px", "Setting border-spacing to `undefined` has no effect" );  
* trailing whitespace (line 361)
test/unit/css.js:361:  
* trailing whitespace (line 364)
test/unit/css.js:364:  equals( jQuery('#tableborderspacing').css("border-spacing"), "2px 1px", "Setting border-spacing to `NaN` has no effect" );  
* trailing whitespace (line 365)
test/unit/css.js:365:  
@csnover

This comment has been minimized.

Copy link
Member

csnover commented Jan 9, 2011

Can’t land this; massive test failures in IE7, Firefox 4.

@rwaldron

This comment has been minimized.

Copy link
Member Author

rwaldron commented Jan 9, 2011

Ok, thanks for the review - I'll revise and address the errors and whitespace; I'll shoot for tomorrow to have this resolved.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 20, 2019
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.