Updated patch for #7102 #166

Closed
wants to merge 10 commits into
from

Conversation

Projects
None yet
2 participants
Contributor

jrburke commented Jan 6, 2011

This is an updated patch that addresses the concerns about making sure an AMD define is called, and that the AMD implementation can support a functionality similar to noConflict. There is more info in an updated comment in the 7102 ticket.

jrburke added some commits Sep 30, 2010

@jrburke jrburke Register as a CommonJS async module if in that kind of environment 93dc7a7
@jrburke jrburke Merge branch 'master' of http://github.com/jquery/jquery d3dd0d5
@jrburke jrburke Update to define() to match Async Module API. 9223483
@jrburke jrburke Merge branch 'master' of http://github.com/jquery/jquery 1084c53
@jrburke jrburke Defining an explicit module called 'jquery', since otherwise, using a…
…nonymous modules in an optimization script that does not know about modules, it can break code that does know about anonymous modules, if both types of scripts are mixed together. 'jquery' was used instead of 'jQuery' because commonjs module identifiers map to file names, and normally the file name for jquery is in lower case.
422b6d3
@jrburke jrburke Merge branch 'master' of http://github.com/jquery/jquery 963212f
@jrburke jrburke Update patch for 7102, with stronger checks for making sure define is…
… called only if an AMD implementation supports multiversion, to match better with noConflict abilities.
d06e138
@jrburke jrburke merge caf02fd
@jrburke jrburke Test for readyWait. 4bcd5f8
@jrburke jrburke Adding second readyWait test for the case when a loader finishes befo…
…re DOMContentLoaded.
9811260

jeresig reopened this Apr 16, 2011

Member

jeresig commented Apr 16, 2011

I'm not sure why this was closed? Can we discuss it for 1.7?

Contributor

jrburke commented Apr 17, 2011

I was going to do a better, proper patch conforming to the sane jQuery policy of "use a branch for each ticket pull" instead of the goofy thing I did where I had other changes in my master fork so the actual change for #7102 got mixed up in other commits. I'll create a fresh jQuery fork with a ticket branch, create a fresh pull, and add it to ticket #7102. I should have it up later tonight.

jrburke closed this Apr 17, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment