Avoid sed due to portability issues between GNU and BSD versions #214

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@joshvarner
Contributor

joshvarner commented Jan 30, 2011

I noticed that the recent commit (ba43d37) to fix sed caused the semicolon to disappear from the end of the final jquery.min.js. Looking further into it, it appears that the Mac OS X (10.6.6) version of sed doesn't support the .\+ syntax. I tried replacing it with .\{1,\} only to discover that the BSD sed also doesn't support inserting newline characters in the replacement string. It simply adds an 'n'.

To avoid these issues, this pull request's commit replaces the sed call with a simple post-compile script that uses node.

@mathiasbynens

This comment has been minimized.

Show comment Hide comment
@mathiasbynens

mathiasbynens Jan 31, 2011

Contributor

+1 No crazy Unicode hackery, no Uglify.js monkey-patching.

Tested on OS X 10.6.6 with Node.js 0.3.7; works flawlessly.

Contributor

mathiasbynens commented Jan 31, 2011

+1 No crazy Unicode hackery, no Uglify.js monkey-patching.

Tested on OS X 10.6.6 with Node.js 0.3.7; works flawlessly.

@jitter

This comment has been minimized.

Show comment Hide comment
@jitter

jitter Feb 12, 2011

Contributor

Landed 2862f58

Thanks. This is what I should have come up with in the first place

Contributor

jitter commented Feb 12, 2011

Landed 2862f58

Thanks. This is what I should have come up with in the first place

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment