Event: Fix delegated radio events when arrow keys are used #2617
Conversation
dmethvin
force-pushed
the
2343-delegated-radio
branch
from
ec438b6
to
047b060
Compare
|
How about we create a test in https://github.com/jquery/jquery/tree/master/test/integration, right now, @timmywil checks this before the release and later, we will automate it - #2329 |
| // Support: Firefox<=42+ | ||
| // Avoid non-left-click in FF but don't block IE radio events (#3861, gh-2343) | ||
| if ( delegateCount && cur.nodeType && | ||
| ( event.type !== "click" || isNaN( event.button ) || event.button < 1 ) ) { |
There was a problem hiding this comment.
What about … && !(event.type === "click" && event.button >= 1)?
There was a problem hiding this comment.
I thought about that, the original !event.button handles both 0 and undefined but it's not obvious. The three conditions make it a bit clearer I think and the second two checks aren't reached except on click events, which are low frequency.
There was a problem hiding this comment.
That's true both ways, and there's no practical performance difference. It's just smaller without the isNaN, and the explanation is already handled pretty well by our support comment (which could become "Suppress clicks of non-primary mouse buttons" if you want to increase clarity a little more).
Fixes gh-2343, gh-2410
This turned out to be trickier than I hoped. Click events that are fired by
$.fn.trigger()don't have anevent.buttonset at all. Also I couldn't figure out a way to test this, for similar reasons. I can set up a unit test that has a fake event with similar incorrect settings as Firefox gives us, but that seems like a bad idea. Ideally this would be a feature detect but that is also impossible since it requires a real user-initiated click and not a fake one.