New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#8101 - lrbabe request animation frame (some adjustments and style edits) #298

Merged
merged 11 commits into from Apr 10, 2011

Conversation

Projects
None yet
3 participants
@timmywil
Member

timmywil commented Apr 4, 2011

  • Moved support.js check to effects.js. This is just an assignment to the function if it exists. Removed string concatenations.
    • Still need to do the checks on window, but after that, window is no longer needed.
  • Switched ternary to an if statmenet
  • assigned timerId to a number rather than the function. I did perf tests to check which is faster.
  • rebased to master

louisremi and others added some commits Jan 31, 2011

timmywil
Some adjustments and style edits on lrbabe's pull for requestAnimatio…
…nFrame

- Moved support.js check to effects.js.  This is just an assignment to the function if it exists.  Removed string concatenations.

  + Still need to do the checks on window, but after that, window is no longer needed.

- Switched ternary to an if statmenet

- assigned timerId to a number rather than the function. I did perf tests to check which is faster.
Show outdated Hide outdated src/effects.js

@jeresig jeresig merged commit 791402b into jquery:master Apr 10, 2011

@kof

This comment has been minimized.

Show comment
Hide comment
@kof

kof Jan 4, 2014

I didn't find why it has been removed, here is a better raf shim ... https://github.com/kof/animationFrame

kof commented Jan 4, 2014

I didn't find why it has been removed, here is a better raf shim ... https://github.com/kof/animationFrame

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment