Tests: Update the loader so test pages always get jQuery #3489

Merged
merged 1 commit into from Jan 9, 2017

Projects

None yet

4 participants

@gibson042
Member

This helped work on gh-3487.

@mention-bot

@gibson042, thanks for your PR! By analyzing the history of the files in this pull request, we identified @timmywil and @markelog to be potential reviewers.

@markelog
Member
markelog commented Jan 5, 2017

Why is this needed?

@gibson042
Member

It's not needed, but being able to open the iframe-test pages in a browser tab and make the same jQuery calls as their respective tests is definitely a worthwhile convenience, especially when we can get it without breaking anything. But absent this fix, opening e.g. test/data/offset/absolute.html generates Uncaught TypeError: Cannot read property 'config' of undefined from https://github.com/jquery/jquery/blob/a8816caf26c0acc7067cd5bad9c03cfb54e54979/test/jquery.js#L11 , and subsequently fails to load jQuery.

@markelog
Member
markelog commented Jan 6, 2017

Cool! Could you put that explanation in the commit? :)

@gibson042 gibson042 Tests: Update the loader so test pages always get jQuery
Pages used for iframe tests will now successfully load jQuery, even when
opened directly in the browser.
dc41a56
@gibson042
Member

Done.

@timmywil timmywil added this to the 3.2.0 milestone Jan 9, 2017
@gibson042 gibson042 merged commit 14b393d into jquery:master Jan 9, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment