Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cached rspaces regex definitions consistent. Fixes #9008 #358

Closed
wants to merge 1 commit into from

Conversation

@rwaldron
Copy link
Member

rwaldron commented Apr 28, 2011

Tested and passing

  • FF 3.0.x, 3.6.x, 4.x
  • Chrome current-1 ( 10, 11 )
  • Safari 3, 4, 5
  • IE 6, 7, 8
  • Opera current-1 ( 11.01, 11.10 )

Not tested in IE 9

@timmywil

This comment has been minimized.

Copy link
Member

timmywil commented Apr 28, 2011

Landed in 57f56be04f

@timmywil timmywil closed this Apr 28, 2011
@timmywil

This comment has been minimized.

Copy link
Member

timmywil commented Apr 28, 2011

I tested full suite in IE9 and reran Chrome, F4 and IE6 for posterity.

@rwaldron

This comment has been minimized.

Copy link
Member Author

rwaldron commented Apr 28, 2011

Awesome, good lookin' out.

@jeresig

This comment has been minimized.

Copy link
Member

jeresig commented Apr 29, 2011

Uhhh - why'd you remove the /g from the second regexp? That doesn't create the same result.

@rwaldron

This comment has been minimized.

Copy link
Member Author

rwaldron commented Apr 29, 2011

With or without the global flag, the test suite is full pass. This leads me to believe the suite is not testing anything that requires a global match on spaces.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.