Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
added array feature to addClass, removeClass and toggleClass #3727
Thanks for the PR!
In it's current version it's way too big, though; it adds 182 bytes to the minified gzipped build (you'll see that if you run
grunt). The diff should be very small, e.g. in
addClass there's just one place where we create an array by splitting a space-separated class list (I added a comment there); that assignment can be skipped in the case where we already get an array but the rest of the code should be fine; no need to repeat it.
Also, make sure to run
grunt locally and you'll see your changes don't follow the jQuery style guide, there are a lot of issues to fix.
You'll also need to add tests for the feature.