Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Tests: Add support for running unit test via Grunt with Karma #3744
The tests are passing to show that the basic infrastructure works, but the majority of Ajax tests has not been ported yet (passing because I commented them out). There are also a number of tests outside
Looking for further feedback before I port the rest.
This is awesome, @Krinkle.
I think it's fine that Karma tests don't run AJAX tests for the time being, it still helps in the majority
We should strive to reduce duplication, though, in the current state of the PR a lot of HTML fixtures are repeated in various files.
@mgol Regarding fixture duplication, I agree. I'll try and generate these automatically in some way with a precommit/pretest Grunt task perhaps.
I'd actually much prefer to move it to a separate file (e.g.
The main reason this isn't viable at the moment is because of traversal tests depending on
I'll get rid of that as well, in a separate commit before this one.