New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3384: deprecate jQuery.camelCase #3874

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@timmywil
Member

timmywil commented Dec 4, 2017

Summary

Makes adjustments to #3604 to fix #3384.

Checklist

niltoncsr and others added some commits Nov 22, 2017

Core: adjust data tests to ensure proper camelCasing
- Add back camelCase to the public object (deprecate not remove)
Ref #3384

@timmywil timmywil changed the title from 3384 to Fixes #3384: deprecate jQuery.camelCase Dec 4, 2017

@timmywil timmywil referenced this pull request Dec 4, 2017

Closed

Hide jQuery.camelCase #3604

@@ -45,7 +45,6 @@ var
// checked="checked" or checked
rchecked = /checked\s*(?:[^=]|=\s*.checked.)/i,
rscriptTypeMasked = /^true\/(.*)/,

This comment has been minimized.

@dmethvin

dmethvin Dec 20, 2017

Member

The changes in this file seem unrelated to the PR?

@dmethvin

dmethvin Dec 20, 2017

Member

The changes in this file seem unrelated to the PR?

This comment has been minimized.

@timmywil

timmywil Dec 20, 2017

Member

Indeed. I didn't see that before. Nice catch!

@timmywil

timmywil Dec 20, 2017

Member

Indeed. I didn't see that before. Nice catch!

@timmywil

This comment has been minimized.

Show comment
Hide comment
@timmywil

timmywil Jan 8, 2018

Member

Merged in 775caeb

Member

timmywil commented Jan 8, 2018

Merged in 775caeb

@timmywil timmywil closed this Jan 8, 2018

@timmywil timmywil deleted the timmywil:3384 branch Jan 8, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Jul 7, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.