New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS: deprecate jQuery.cssProps #3892

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@timmywil
Member

timmywil commented Dec 18, 2017

Fixes gh-3653

Summary

Deprecates the now empty jQuery.cssProps. It's still used for the vendor prefix cache, but no longer has any properties to map to different names for each browser.

Checklist

@mgol

I have one important remark.

Also, can you create a Migrate issue if one doesn't exist yet or link to one if it exists?

@@ -38,5 +39,6 @@ jQuery.isArray = Array.isArray;
jQuery.parseJSON = JSON.parse;
jQuery.nodeName = nodeName;
jQuery.isWindow = isWindow;
jQuery.cssProps = cssProps;

This comment has been minimized.

@mgol

mgol Dec 18, 2017

Member

I'm afraid it might be a breaking change. The fact that the object is now injected instead of used directly from jQuery.cssProps means that if someone overwrites the object completely it will stop working.

Perhaps we should just move defining this object here and in source, where it's used, make sure code still works fine if it's not defined.

Or just deprecate in docs without touching the code base. Whatever you prefer.

@mgol

mgol Dec 18, 2017

Member

I'm afraid it might be a breaking change. The fact that the object is now injected instead of used directly from jQuery.cssProps means that if someone overwrites the object completely it will stop working.

Perhaps we should just move defining this object here and in source, where it's used, make sure code still works fine if it's not defined.

Or just deprecate in docs without touching the code base. Whatever you prefer.

This comment has been minimized.

@mgol

mgol Dec 18, 2017

Member

The same for an API ticket.

@mgol

mgol Dec 18, 2017

Member

The same for an API ticket.

This comment has been minimized.

@timmywil

timmywil Jan 8, 2018

Member

Good point. cssProps brought up no search results on api.jquery.com, so I'm not sure it's actually mentioned anywhere. Maybe there's nothing to do here?

@timmywil

timmywil Jan 8, 2018

Member

Good point. cssProps brought up no search results on api.jquery.com, so I'm not sure it's actually mentioned anywhere. Maybe there's nothing to do here?

@timmywil timmywil closed this Jan 8, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Jul 7, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.