New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibly-unitless CSS grid properties #4028

Merged
merged 2 commits into from Aug 29, 2018

Conversation

Projects
None yet
3 participants
@enbo
Contributor

enbo commented Mar 29, 2018

Summary

Fixes #4007

Checklist

@enbo

This comment has been minimized.

Owner

enbo commented on 078ed8d Mar 28, 2018

Fixes jquery#4007

Merge pull request #1 from enbo/cssNumber
Add possibly-unitless CSS grid properties
@enbo

This comment has been minimized.

Contributor

enbo commented Mar 29, 2018

@mgol I'll start to look through the unit test you linked back in #4007:

jquery/test/unit/css.js

Lines 1120 to 1144 in 73d7e62

QUnit.test( "Do not append px (#9548, #12990, #2792)", function( assert ) {
assert.expect( 3 );
var $div = jQuery( "<div>" ).appendTo( "#qunit-fixture" );
$div.css( "fill-opacity", 1 );
assert.equal( $div.css( "fill-opacity" ), 1, "Do not append px to 'fill-opacity'" );
$div.css( "column-count", 1 );
if ( $div.css( "column-count" ) !== undefined ) {
assert.equal( $div.css( "column-count" ), 1, "Do not append px to 'column-count'" );
} else {
assert.ok( true, "No support for column-count CSS property" );
}
$div.css( "animation-iteration-count", 2 );
if ( $div.css( "animation-iteration-count" ) !== undefined ) {
// if $div.css( "animation-iteration-count" ) return "1",
// it actually return the default value of animation-iteration-count
assert.equal( $div.css( "animation-iteration-count" ), 2, "Do not append px to 'animation-iteration-count'" );
} else {
assert.ok( true, "No support for animation-iteration-count CSS property" );
}
} );

@timmywil

This comment has been minimized.

Member

timmywil commented Apr 23, 2018

This needs tests, but can be merged in 3.4 once that happens.

@mgol

Marking as a WIP as it needs tests.

@mgol

This comment has been minimized.

Member

mgol commented Jun 10, 2018

@enbo Hey, will you have time to work on the tests soon? If not, please let us know so that we can proceed ourselves here. Thanks!

@enbo

This comment has been minimized.

Contributor

enbo commented Jun 10, 2018

@mgol I apologize for the radio silence! Lots of transition going on in life right now so I won't be able to complete the tests soon.

@mgol

This comment has been minimized.

Member

mgol commented Jun 11, 2018

@mgol mgol merged commit f997241 into jquery:master Aug 29, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@mgol

This comment has been minimized.

Member

mgol commented Aug 29, 2018

Landed, thanks!

mgol added a commit to mgol/jquery that referenced this pull request Aug 29, 2018

mgol added a commit to mgol/jquery that referenced this pull request Oct 3, 2018

mgol added a commit that referenced this pull request Oct 3, 2018

@GulajavaMinistudio GulajavaMinistudio referenced this pull request Oct 3, 2018

Merged

The compiler reported twice #61

0 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment