Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Removes unused hasOwn var declaration. Fixes #9510 #404

Closed
wants to merge 1 commit into from

3 participants

Rick Waldron Timmy Willison Mike Sherov
Rick Waldron
Collaborator

No description provided.

Mike Sherov
Collaborator

This file, events.js has a whole bunch of other stylistic issues, including but not limited to, multiple vat declarations per function, var declarations in loops, unused variables, and whitespacing. I assume it hasn't really been touched in a bit?

Collaborator

yeah bro.. It's on the rewrite list for 1.7 - Dave Methvin has some great plans for cleaning this up

Collaborator

Cool. Just curious, is that on the bug tracker, or listed somewhere? I was going to start doing that cleanup myself, and I would rather work on something that one of the core members isn't. Thanks again!

Collaborator

Dave Methvin is doing the major re-write tasks http://bugs.jquery.com/ticket/9393 - the man has a plan! :D

Timmy Willison
Collaborator

Landed in commit c3c001c.

Timmy Willison timmywil closed this June 06, 2011
Sara Chipps SaraJo referenced this pull request October 29, 2011
Closed

Patch for ticket #9830 #567

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 1 unique commit by 1 author.

Jun 03, 2011
Rick Waldron Removes unused hasOwn var declaration. Fixes #9510 821deda
This page is out of date. Refresh to see the latest.

Showing 1 changed file with 1 addition and 2 deletions. Show diff stats Hide diff stats

  1. 3  src/event.js
3  src/event.js
... ...
@@ -1,7 +1,6 @@
1 1
 (function( jQuery ) {
2 2
 
3  
-var hasOwn = Object.prototype.hasOwnProperty,
4  
-	rnamespaces = /\.(.*)$/,
  3
+var rnamespaces = /\.(.*)$/,
5 4
 	rformElems = /^(?:textarea|input|select)$/i,
6 5
 	rperiod = /\./g,
7 6
 	rspaces = / /g,
Commit_comment_tip

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.