New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: ensure support tests are failed by at least one tested browser #4052

Merged
merged 1 commit into from Apr 23, 2018

Conversation

Projects
None yet
2 participants
@mgol
Member

mgol commented Apr 23, 2018

Summary

This PR ensures support tests are failed by at least one tested browser.

A whitelist is available so that some tests can be allowed to always succeed.
This is used only for ajax for now as it can be manually disabled in IE but
is enabled by default.

Checklist

@timmywil

This comment has been minimized.

Member

timmywil commented Apr 23, 2018

I love this.

@@ -305,4 +319,38 @@ testIframe(
}
} );
QUnit.test( "Verify most support tests are failing in one " +
"of tesed browsers", function( assert ) {

This comment has been minimized.

@mgol

mgol Apr 23, 2018

Member

s/tesed/tested/

Tests: ensure support tests are failed by at least one tested browser
A whitelist is available so that some tests can be allowed to always succeed.
This is used only for ajax for now as it can be manually disabled in IE but
is enabled by default.

Closes gh-4052

@mgol mgol merged commit 9a5b3b6 into jquery:master Apr 23, 2018

2 of 3 checks passed

continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details

@mgol mgol deleted the mgol:support-tests-needed branch Apr 23, 2018

@GulajavaMinistudio GulajavaMinistudio referenced this pull request Apr 24, 2018

Merged

Update upstream #46

0 of 4 tasks complete

@mgol mgol removed the Needs review label Apr 30, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Oct 27, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.