jQuery.clone() check destination child nodes are not null. Fixes #9587 #412

Merged
merged 1 commit into from Aug 4, 2011
Jump to file or symbol
Failed to load files and symbols.
+18 −2
Split
View
@@ -564,7 +564,10 @@ jQuery.extend({
// with an element if you are cloning the body and one of the
// elements on the page has a name or id of "length"
for ( i = 0; srcElements[i]; ++i ) {
- cloneFixAttributes( srcElements[i], destElements[i] );
+ // Ensure that the destination node is not null; Fixes #9587
+ if ( destElements[i] ) {
+ cloneFixAttributes( srcElements[i], destElements[i] );
+ }
}
}
@@ -762,4 +765,4 @@ function evalScript( i, elem ) {
}
}
-})( jQuery );
+})( jQuery );
View
@@ -281,6 +281,8 @@ <h2 id="qunit-userAgent"></h2>
</div>
<div id="fx-tests"></div>
+
+ <div id="no-clone-exception"><object><embed></embed></object></div>
</div>
</body>
</html>
View
@@ -1465,3 +1465,14 @@ test("jQuery.buildFragment - plain objects are not a document #8950", function()
} catch (e) {}
});
+
+test("jQuery.clone - no exceptions for object elements #9587", function() {
+ expect(1);
+
+ try {
+ jQuery("#no-clone-exception").clone();
+ ok( true, "cloned with no exceptions" );
+ } catch( e ) {
+ ok( false, e.message );
+ }
+});