Tests: Allow Karma to load unminfied source #4128
Conversation
|
@gibson042 The |
|
@timmywil That was surprisingly tricky to address, but should be good to go now. |
There was a problem hiding this comment.
The AMD mode doesn't seem to work. For example, choosing the support module and enabling AMD mode leads to an all-red outcome. Moreover, most modules are not available under the dropdown when the AMD mode is selected. Pressing "Rerun" on a specific test doesn't fire tests just for it but also for many others, etc.
test/data/testinit.js
Outdated
| // except when running tests in Karma (See Gruntfile) | ||
| // Tests are always loaded async | ||
| // except when running tests in Karma (See Gruntfile) | ||
| if ( !window.__karma__ ) { |
There was a problem hiding this comment.
A double space incorrectly got inserted after __karma__.
gibson042
force-pushed
the
2018-07-karma-debug-unminified
branch
from
782e643
to
22d3349
Compare
|
Right, AMD behavior is at odds with the way the tests are currently loaded in Karma. I just removed that mode, because it doesn't provide much value over e.g. |
What do you mean by that? |
|
I typed the wrong example command, and looking back it wasn't really coherent anyway. Please disregard. However, we still don't have AMD mode in Karma, and I'm disinclined to force that in scope for this PR (there's no loss, since current master lacks both AMD and unminified). Someone else can make those changes later if they so desire. |
|
I agree, adding AMD support is a separate feature request. |
Summary
Makes Karma behave more like the old tests by exposing a "load unminified" checkbox.
Checklist
If needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com