New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Begrudgingly adds chrome detection to jQuery.browser (1.7). Fixes #9385 #417

Merged
merged 2 commits into from Aug 4, 2011

Conversation

Projects
None yet
4 participants
@rwaldron
Member

rwaldron commented Jun 20, 2011

Pretty straightforward here....

@timmywil

This comment has been minimized.

Show comment
Hide comment
@timmywil

timmywil Jun 22, 2011

Member

In that case, $.browser.safari should probably not be the same as $.browser.webkit.

....or

delete $.browser
Member

timmywil commented Jun 22, 2011

In that case, $.browser.safari should probably not be the same as $.browser.webkit.

....or

delete $.browser
@timmywil

This comment has been minimized.

Show comment
Hide comment
@timmywil

timmywil Jun 22, 2011

Member

Actually, that might be an argument against doing either and removing $.browser.safari.

Member

timmywil commented Jun 22, 2011

Actually, that might be an argument against doing either and removing $.browser.safari.

@curiousdannii

This comment has been minimized.

Show comment
Hide comment
@curiousdannii

curiousdannii Jun 23, 2011

Why not $.browser.v8? (As that is, I presume, what people are really after.)

curiousdannii commented Jun 23, 2011

Why not $.browser.v8? (As that is, I presume, what people are really after.)

@rwaldron

This comment has been minimized.

Show comment
Hide comment
@rwaldron

rwaldron Jun 23, 2011

Member

@curiousdannii, that's not what they are looking for. The request was for $.browser.chrome to differentiate a chrome webkit

Member

rwaldron commented Jun 23, 2011

@curiousdannii, that's not what they are looking for. The request was for $.browser.chrome to differentiate a chrome webkit

dmethvin added a commit that referenced this pull request Aug 4, 2011

Merge pull request #417 from rwldrn/9385
Begrudgingly adds chrome detection to jQuery.browser (1.7). Fixes #9385

@dmethvin dmethvin merged commit 5417a2c into jquery:master Aug 4, 2011

markelog pushed a commit to markelog/jquery that referenced this pull request Aug 9, 2011

Merge pull request jquery#417 from rwldrn/9385
Begrudgingly adds chrome detection to jQuery.browser (1.7). Fixes #9385
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment