New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manipulation: Only evaluate HTTP-successful script src #4243

Merged
merged 2 commits into from Dec 12, 2018

Conversation

Projects
None yet
4 participants
@gibson042
Member

gibson042 commented Nov 26, 2018

Fixes gh-4126

Checklist

@timmywil

LGTM

@dmethvin

LGTM

@mgol

mgol approved these changes Dec 3, 2018

LGTM. I'd prefer fixing dataType: "script" handling so that it doesn't evaluate unsuccessful scripts and I'd like to evaluate that for jQuery 4.0. For jQuery 3.4 this change looks good.

@mgol mgol merged commit c2026b1 into jquery:master Dec 12, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@mgol

This comment has been minimized.

Member

mgol commented Dec 12, 2018

@gibson042 I merged the PR but it broke tests in IE 9-11 & iOS 7-9: http://swarm.jquery.org/job/8524

gibson042 added a commit to gibson042/jquery that referenced this pull request Dec 13, 2018

Manipulation: Always make _evalUrl requests as dataType: script
IE and iOS <10 XHR transport does not succeed on data: URIs
Ref jquerygh-4243
Ref jquerygh-4126

gibson042 added a commit that referenced this pull request Dec 13, 2018

Manipulation: Restore _evalUrl jQuery.ajax calls to dataType: script
IE and iOS <10 XHR transport does not succeed on data: URIs
Ref gh-4243
Ref gh-4126
Closes gh-4258
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment