Core: Support passing nonce through jQuery.globalEval

[mgol]

Summary

Support passing nonce through jQuery.globalEval:

jQuery.globalEval( code, nonceValue );

Fixes gh-4278
Ref gh-3541
Ref gh-4269

Checklist

• All authors have signed the CLA at https://cla.js.foundation/jquery/jquery
• New tests have been added to show the fix or feature works
• Grunt build and unit tests pass locally with these changes
• If needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com

Docs issue: jquery/api.jquery.com#1123

[mgol]

I'll create docs issue if this gets accepted.

[mgol]

This is -1 +1 byte but that's a clever lie. It turns out you can set nonce via setAttribute, you just can't trust getAttribute( "nonce" ). Thus, I simplified the previous code which allowed to achieve the size decrease. Just applying the refactor without adding support for #4278 would give -11 bytes. So, effectively, this is +10 +12 bytes.

[mgol]

The biggest question is: is this API OK? Or would you rather see something else?

[gibson042]

I don't like the signature, one could easily imagine a realm parameter occupying that position. And I don't really feel great about an options object here, but maybe that is the best approach. :\

[mgol]

Makes sense. I was also not quite happy about the signature but it's not a boolean so it's not that bad and I wasn't sure if an object isn't too much (we don't have a lot of APIs with one-prop object params, I think).

The object syntax const is just additional 2 bytes, not bad. Changes here: mgol@e49e3e8.

[mgol]

Another version: mgol@8d9cf5e. Gzipped size is the same as mgol@e49e3e8, minified non-gzipped size is smaller by 7 bytes. And we're losing the getAttribute hacky check so perhaps that's better.

EDIT: This version is broken as we still need the getAttribute fallback for non-nonce params. But mgol@e49e3e8 is fine.

[timmywil]

I prefer the options object, even if there's only one option.

[mgol]

@timmywil @gibson042 Cool. I updated the PR to use the options object. The old version is at mgol@0d92506 if anyone wanted to have a look.

[gibson042]

👍

[timmywil]

LGTM

[timmywil]

LGTM

[mgol]

Docs issue: jquery/api.jquery.com#1123