Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

ticket 7071 - Accessing the 'type' property on VML elements fails on IE #434

Merged
merged 1 commit into from over 2 years ago

4 participants

Bubbi Rick Waldron Dave Methvin robertvogel
Bubbi
Bubbi commented July 15, 2011

Make sure that Internet Explorer 6-8 won't give a "failed" error, when a request for type is made on vml objects.

Testcase for the bug can be found here: http://jsfiddle.net/7p3Yr/23/

Rick Waldron
Collaborator

Please provide a test/unit/event.js test

robertvogel

Hey -

I think I have a simple reduced case that should help - here it is:

http://www.peakdemocracy.com/p/demo/error/statements1.html

Click on the polygon (triangle) and you'll see the error in IE7/8. The error disappears when you remove jquery-ujs, or when you remove

disableDefaultUI: true,

in the options for the googlemap.

Dave Methvin
Owner

This change made it into the IE change special handler but for some reason wasn't applied to the submit one as well.

Dave Methvin dmethvin merged commit 84936f1 into from August 04, 2011
Dave Methvin dmethvin closed this August 04, 2011
Oleg Gaidarenko markelog referenced this pull request from a commit August 08, 2011
Commit has since been removed from the repository and is no longer available.
DavidDufresne DavidDufresne referenced this pull request from a commit April 25, 2013
Commit has since been removed from the repository and is no longer available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 1 unique commit by 1 author.

Jul 15, 2011
Bubbi Make sure that Internet Explorer 6-8 won't give a "failed" error, whe…
…n a request for type is made on vml objects
2d275df
This page is out of date. Refresh to see the latest.

Showing 1 changed file with 4 additions and 3 deletions. Show diff stats Hide diff stats

  1. 7  src/event.js
7  src/event.js
@@ -703,7 +703,7 @@ if ( !jQuery.support.submitBubbles ) {
703 703
 			if ( !jQuery.nodeName( this, "form" ) ) {
704 704
 				jQuery.event.add(this, "click.specialSubmit", function( e ) {
705 705
 					var elem = e.target,
706  
-						type = elem.type;
  706
+						type = jQuery.nodeName( elem, "input" ) ? elem.type : "";
707 707
 
708 708
 					if ( (type === "submit" || type === "image") && jQuery( elem ).closest("form").length ) {
709 709
 						trigger( "submit", this, arguments );
@@ -712,7 +712,7 @@ if ( !jQuery.support.submitBubbles ) {
712 712
 
713 713
 				jQuery.event.add(this, "keypress.specialSubmit", function( e ) {
714 714
 					var elem = e.target,
715  
-						type = elem.type;
  715
+						type = jQuery.nodeName( elem, "input" ) ? elem.type : "";
716 716
 
717 717
 					if ( (type === "text" || type === "password") && jQuery( elem ).closest("form").length && e.keyCode === 13 ) {
718 718
 						trigger( "submit", this, arguments );
@@ -737,7 +737,8 @@ if ( !jQuery.support.changeBubbles ) {
737 737
 	var changeFilters,
738 738
 
739 739
 	getVal = function( elem ) {
740  
-		var type = elem.type, val = elem.value;
  740
+		var type = jQuery.nodeName( elem, "input" ) ? elem.type : "",
  741
+			val = elem.value;
741 742
 
742 743
 		if ( type === "radio" || type === "checkbox" ) {
743 744
 			val = elem.checked;
Commit_comment_tip

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.