Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ajax: Deprecate AJAX event aliases, inline event/alias into deprecated #4572

Merged
merged 1 commit into from Jan 21, 2020

Conversation

mgol
Copy link
Member

@mgol mgol commented Dec 16, 2019

Summary

Deprecate AJAX event aliases, inline event/alias.js into deprecated.js.

Regular event aliases are already deprecated, this brings the AJAX ones in line with all the others.

As for inlining - it doesn't make sense to me to have almost all deprecated stuff in deprecated.js but only event aliases in event/alias.js - but still only imported from deprecated.js.

If accepted, this should be cherry-picked to 3.x-stable as well.

Checklist

@mgol mgol added this to the 3.5.0 milestone Dec 16, 2019
src/deprecated.js Outdated Show resolved Hide resolved
@mgol mgol force-pushed the deprecated-event-aliases branch 2 times, most recently from 7f2efd5 to 45edb67 Compare Jan 8, 2020
@mgol
Copy link
Member Author

@mgol mgol commented Jan 8, 2020

Ready for another review.

A new `src/deprecated` directory makes it possible to exclude some deprecated
APIs from a custom build when their respective "parent" module is excluded
without keeping that module outside of the `src/deprecated` directory or
the `src/deprecated.js` file.
@mgol mgol force-pushed the deprecated-event-aliases branch from 45edb67 to c3ee62a Compare Jan 13, 2020
@mgol mgol self-assigned this Jan 13, 2020
@mgol mgol removed the Needs review label Jan 21, 2020
@mgol mgol merged commit 23d5392 into jquery:master Jan 21, 2020
2 checks passed
@mgol mgol changed the title Ajax: Deprecate AJAX event aliases, inline event/alias.js into deprecated.js Ajax: Deprecate AJAX event aliases, inline event/alias into deprecated Jan 21, 2020
@mgol mgol deleted the deprecated-event-aliases branch Jan 21, 2020
@mgol
Copy link
Member Author

@mgol mgol commented Jan 21, 2020

Landed on master at 23d5392 and on 3.x-stable at 7a3cf9c.

mgol added a commit that referenced this issue Jan 21, 2020
A new `src/deprecated` directory makes it possible to exclude some deprecated
APIs from a custom build when their respective "parent" module is excluded
without keeping that module outside of the `src/deprecated` directory or
the `src/deprecated.js` file.

Closes gh-4572

(cherry picked from 23d5392)
mgol added a commit to mgol/jquery that referenced this issue Jan 21, 2020
The file contents now lie in deprecated/event.js so the README reference
is no longer correct.

Ref jquerygh-4572
mgol added a commit that referenced this issue Jan 27, 2020
The file contents now lie in deprecated/event.js so the README reference
is no longer correct.

Ref gh-4572
Closes gh-4599
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants