Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test cache for window inference. Fixes #10080 #468

Merged
merged 2 commits into from Aug 25, 2011

Conversation

Projects
None yet
4 participants
@rwaldron
Copy link
Member

rwaldron commented Aug 17, 2011

Includes tests by Brian Moschel - Thanks!

@rwaldron

This comment has been minimized.

Copy link
Member Author

rwaldron commented Aug 17, 2011

Im going to try this again.

@timmywil

This comment has been minimized.

Copy link
Member

timmywil commented Aug 17, 2011

I see it's different now. I just saw cache[id]. You are probably having issues because I did a forced push so that dmethvin would be correctly named the author of a certain pull request for which I edited the whitespace. Sorry about that. fetch and then rebranch or git pull --rebase upstream master should do the trick.

@rwaldron

This comment has been minimized.

Copy link
Member Author

rwaldron commented Aug 17, 2011

All set now!

@rwaldron

This comment has been minimized.

Copy link
Member Author

rwaldron commented Aug 18, 2011

Updates, with additional perf data here: http://jsperf.com/iswindow-vs-inline-test

Tested and passing in all supported browsers, as evidenced by perf tests

dmethvin added a commit that referenced this pull request Aug 25, 2011

Merge pull request #468 from rwldrn/10080
Fixes #10080. Test cache for window inference.

@dmethvin dmethvin merged commit f4811bf into jquery:master Aug 25, 2011

@pomeh

This comment has been minimized.

Copy link

pomeh commented on src/data.js in 93beee8 Nov 4, 2011

Why not using jQuery.isWindow method here ?

This comment has been minimized.

Copy link
Member Author

rwaldron replied Nov 4, 2011

Because there is no need to add a function call to the stack

markelog pushed a commit to markelog/jquery that referenced this pull request Jan 11, 2012

Merge pull request jquery#468 from rwldrn/10080
Fixes #10080. Test cache for window inference.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 21, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.