Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

1.7 - queue refactoring to handle delay stop - Fixes #6150 #514

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
Owner

gnarf commented Sep 21, 2011

Adding a second parameter passed to .queue functions. This parameter points at a private data object. Setting a stop property to be a function on this parameter will add a hook for the .stop() call to get passed along.

Also adds support for .stop() on a single queue as opposed to all queues. If we decide to turn down the stop hooks, the single queue option for .stop() might still want to be investigated. Now that .animate() can work in multiple queues, it might be nice to stop only one of them.

Owner

dmethvin commented Sep 23, 2011

Seems like the scope for this crept beyond the bugfix that seemed to be in 6150. Is there a simpler fix for the reported bug? I am wondering if this might be best to tackle with the 1.8 event refactoring.

Owner

gnarf commented Sep 23, 2011

It did creep beyond, but the "beyond" part is mostly handling multiple queues in stop. I figured since I added multiple animate queues, this might be needed now. The default for stop is to stop all animates.

The code for the "creep" part of it is really only part of two if statements, and one assignment.

Owner

dmethvin commented Sep 23, 2011

Well darn, I was hoping that we'd be able to save some bytes.

Owner

timmywil commented Sep 28, 2011

Landed in commit a3b59d7.

@timmywil timmywil closed this Sep 28, 2011

mescoda pushed a commit to mescoda/jquery that referenced this pull request Nov 4, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment