Patch for ticket #9830 #567

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants

SaraJo commented Oct 29, 2011

Fixed with jollysonali jyli7. We made the adjustment in line #404 of attributes.js. The attrHooks' get function sends back the getAttribute value of the element if present. If it's not present, it defaults to the current value of the element.

Let us know if you have any feedback, thank you!

Member

rwaldron commented Oct 30, 2011

Awesome - can you add a test for this? Thanks!

Owner

timmywil commented Oct 30, 2011

There are several issues here. Most of all, the property retrieval is the only reason the value attrHook exists. The only solution is removing it.

timmywil closed this Oct 30, 2011

SaraJo commented Oct 31, 2011

I agree that it seems verbose, shall we add a conditional in the attr:
function?
Sara J Chipps
http://SaraJChipps.com
http://GirlDevelopIt.com
sarajchipps@gmail.com
862.201.3065


No trees were killed in sending this message but a large number of
electrons were terribly inconvenienced.

On Sun, Oct 30, 2011 at 2:06 PM, timmywil <
reply@reply.github.com>wrote:

There are several issues here. Most of all, the property retrieval is the
only reason the value attrHook exists. The only solution is removing it.

Reply to this email directly or view it on GitHub:
#567 (comment)

Owner

timmywil commented Oct 31, 2011

For now, this can be added to a project that expects to retrieve the value attribute:

delete jQuery.attrHooks.value;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment