Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

fixes #7986, Bug in $.support.boxModel if page has DIV-element CSS #630

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
2 participants
Member

mikesherov commented Dec 10, 2011

http://jqbug.com/7986

Inspired by @AaronAsAChimp's pull request #406, but with some additional resiliency and DRYing to weigh in at 19 bytes total:

  249884   (+492) jquery.js
   94094   (+116) jquery.min.js
   33375    (+19) jquery.min.js.gz
Owner

dmethvin commented Feb 24, 2012

Landed after yet another rebase. :) a52391a

@dmethvin dmethvin closed this Feb 24, 2012

Owner

dmethvin commented Mar 2, 2012

@mikesherov, I'm now getting a test fail in the bodyBackground iframe test that I somehow missed before, probably something got cached. Are you seeing this too?

Member

mikesherov commented Mar 2, 2012

I had it passing all tests, weird. What browser?

Owner

dmethvin commented Mar 2, 2012

Chrome and Firefox at least. Could have been something I broke but I didn't
think I messed with anything but the commit message. I figured you'd be
able to see anything fishy faster than me.

On Fri, Mar 2, 2012 at 3:40 PM, Mike Sherov <
reply@reply.github.com

wrote:

I had it passing all tests, weird. What browser?


Reply to this email directly or view it on GitHub:
#630 (comment)

Owner

dmethvin commented Mar 2, 2012

Oh waitaminit, this was the one i had to rebase again, so the odds are that either I hosed it or the conflicting commit caused some issue. Ugh.

Member

mikesherov commented Mar 2, 2012

I'm looking into this now.

Member

mikesherov commented Mar 3, 2012

found the problem, bad merge.

Member

mikesherov commented Mar 3, 2012

You left in the old boxModel check when merging. I'll submit a new PR now.

Owner

dmethvin commented Mar 3, 2012

Duh! Thanks for taking care of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment