Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
smaller/stronger domManip/buildFragment/clean #680
One thing that should be noted, despite
I just tried resolving the conflicts this creates by favoring these changes and there seems to be a significant divergence that can't be resolved, so I'll leave it to you to sort that out, since you know your changes better then I
A few more thoughts... this change set disfavors a lot of simple conditions, that are accompanied by comments and ticket numbers in favor of "clever" ternary and lazy evaluation assignment expressions. jQuery used to be full of these and they were hard to maintain and often unclear in their intention, which is why a lot of new code began to use complete _IfStatement_s, with thorough explanations.
Example: https://github.com/jquery/jquery/pull/680/files#L1L475 specifically, 475-480 => 465-466