Skip to content

fixes #10996 (simplify offset) #726

Closed
wants to merge 2 commits into from

4 participants

@mikesherov
jQuery Foundation member

In all of jQuery's supported browsers, either getBoundingClientRect() or window.webkitConvertPointFromNodeToPage() exists, thereby eliminating the need for the old lengthy getOffset function. Good riddance!

http://bugs.jquery.com/ticket/10996

In case anyone is curious, and I know you are, here is the size diff:

jQuery Size - compared to last make
  249938  (-2956) jquery.js
   93290  (-1499) jquery.min.js
   33167   (-470) jquery.min.js.gz
@rwaldron rwaldron commented on an outdated diff Apr 4, 2012
build/jshint-check.js
@@ -12,7 +12,8 @@
smarttabs: true,
predef: [
"define",
- "DOMParser"
+ "DOMParser",
+ "WebKitPoint",
@rwaldron
jQuery Foundation member
rwaldron added a note Apr 4, 2012

I know it's not an issue, really... but drop the trailing comma

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@rwaldron
jQuery Foundation member
rwaldron commented Apr 4, 2012

If this is real, I'm impressed.

mikesherov added some commits Dec 24, 2011
@sindresorhus

Woah, if only there were more pull requests like this! :D

@dmethvin
jQuery Foundation member
dmethvin commented Apr 6, 2012

Landed in 1.8pre: 77536f5

"In recent news, github.com reports that their disk usage decreased significantly thanks to a recent @mikesherov pull request."

@dmethvin dmethvin closed this Apr 6, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.