New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #10996 (simplify offset) #726

Closed
wants to merge 2 commits into
base: 1.8pre
from

Conversation

Projects
None yet
4 participants
@mikesherov
Member

mikesherov commented Apr 3, 2012

In all of jQuery's supported browsers, either getBoundingClientRect() or window.webkitConvertPointFromNodeToPage() exists, thereby eliminating the need for the old lengthy getOffset function. Good riddance!

http://bugs.jquery.com/ticket/10996

In case anyone is curious, and I know you are, here is the size diff:

jQuery Size - compared to last make
  249938  (-2956) jquery.js
   93290  (-1499) jquery.min.js
   33167   (-470) jquery.min.js.gz
Show outdated Hide outdated build/jshint-check.js
@rwaldron

This comment has been minimized.

Show comment
Hide comment
@rwaldron

rwaldron Apr 4, 2012

Member

If this is real, I'm impressed.

Member

rwaldron commented Apr 4, 2012

If this is real, I'm impressed.

mikesherov added some commits Dec 25, 2011

function parity with getBoundingClientRect
return new object literal in all cases
style and JSHint fixes
@sindresorhus

This comment has been minimized.

Show comment
Hide comment
@sindresorhus

sindresorhus Apr 4, 2012

Contributor

Woah, if only there were more pull requests like this! :D

Contributor

sindresorhus commented Apr 4, 2012

Woah, if only there were more pull requests like this! :D

@dmethvin

This comment has been minimized.

Show comment
Hide comment
@dmethvin

dmethvin Apr 6, 2012

Member

Landed in 1.8pre: 77536f5

"In recent news, github.com reports that their disk usage decreased significantly thanks to a recent @mikesherov pull request."

Member

dmethvin commented Apr 6, 2012

Landed in 1.8pre: 77536f5

"In recent news, github.com reports that their disk usage decreased significantly thanks to a recent @mikesherov pull request."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment