Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove webkitConvertPointFromNodeToPage #796
Yeah, i know, i know, you guys voted on it. But hear me out for a minute, from ticket description –
"For older versions of Safari (or older mobile safari) it seems simpler to calculate offset using window.webkitConvertPointFromNodeToPage()."
In what browsers, exactly, we have webkitConvertPointFromNodeToPage and do not have getBoundingClientRect? For desktop browsers it's simple – for Safari, support for webkitConvertPointFromNodeToPage begins from Safari 4, just like for getBoundingClientRect, Chrome always had it.
Mobile browsers? There is no way to reliable know if all mobile webkit-based browsers lists here is have webkitConvertPointFromNodeToPage and do not have getBoundingClientRect. Only way to know that, is to check lowest versions of them all –
And i did – they all have getBoundingClientRect, which means webkitConvertPointFromNodeToPage code path will never be chosen, which means webkitConvertPointFromNodeToPage is dead code and should be removed.
Yeah, I'm with you on this one @Orkel. I kept it in simply because I couldn't really get a great answer from the jQm team on whether or not we needed to support this. I know that the original iPhone is affected by this, but that's about it :-.
I say good riddance. Just let someone complain!