Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fixed issue with 'change' detaching in IE7/IE8. #878

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
Owner

dmethvin commented Jul 27, 2012

Thanks! Can you provide a unit test for this as well?

Member

rwaldron commented Jul 27, 2012

Thanks for the contribution! Changing code to do the exact opposite of what it's presently doing, without a single test to support the change is nervous making. Can you add tests and ensure this doesnt break the current tests?

Contributor

NikGovorov commented Jul 27, 2012

Done. If something is wrong with the test, just let me know. Thanks guys.

@dmethvin dmethvin closed this in ff7b7cf Aug 20, 2012

@NikGovorov NikGovorov referenced this pull request in knockout/knockout Aug 13, 2013

Closed

memory leak knockout 2.3.0 IE8 #1069

mescoda pushed a commit to mescoda/jquery that referenced this pull request Nov 4, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment