Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 7418; Fixes #7418; Adds 2 supporting unit tests; #93

Merged
2 commits merged into from Nov 12, 2010
Merged

Conversation

@rwaldron
Copy link
Member

rwaldron commented Nov 10, 2010

Fixes #7418; Adds 2 supporting unit tests;

@jitter

This comment has been minimized.

Copy link

jitter commented on fdbe3dc Nov 10, 2010

The test you provided doesn't work. If I just apply the changes in test/unit/ajax.js without applying the fix, the test-suite doesn't fail, which it should without the fix.

On a side note: I think doing the check for dangling scripts as a conditional is suboptimal. If the expression evaluates to false the whole test-suite comes to a halt as start() isn't called (because plus() isn't called a second time). So Qunit hangs on this test forever.

Changing to ok(!jQuery("head script[src^='data/jsonp.php']").length, "JSONP leaves no scripts behind"); should fix this.

This comment has been minimized.

Copy link
Owner Author

rwaldron replied Nov 10, 2010

Jitter - Funny thing, that's actually how I had the test set up originally. Thanks for the input I'll get the change in asap.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 20, 2019
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.