Fixes #10416 #941

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
Member

markelog commented Sep 30, 2012

You should never trust computes styles of detached nodes

Why change this part? I'm sure this results in a size increase to add this var/arguments tweaking. We could just add a comment explaining why it does elem = el || elem;, which is that the function can either be called with an element, or used as a "filter" iterator function. The filter funciton passes index, element

Owner

markelog replied Sep 30, 2012

Why change this part? I'm sure this results in a size increase to add this var/arguments tweaking. We could just add a comment explaining why it does elem = el || elem;

Its cost 2 bytes or so, i want to change this part, because for me, this look a bit more eloquent.

which is that the function can either be called with an element, or used as a "filter" iterator function. The filter funciton passes index, element

Yeah, i remember that, since i wrote this function :).

Well, either way, a comment would still be nice, its not very obvious why you're doing it.

dmethvin closed this in bea5ecb Oct 29, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment