Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Fixes #12569 #967

Closed
wants to merge 1 commit into from

2 participants

@fracmak

Switches the bubbling support check to run only if addEVentListener is undefined, not if we detect an IE only function to provide better IE only support checks

@dmethvin dmethvin referenced this pull request from a commit
@dmethvin dmethvin Revert "Fixes #12569. Improve Feature Detect For oldIE bubbling. closes
gh-967"

This reverts commit 063ea02.

I've beaten on this for a while and can't find a suitable feature detect that catches Chrome's support for focusin.
05fb5de
@mescoda mescoda referenced this pull request from a commit in mescoda/jquery
@dmethvin dmethvin Revert "Fixes #12569. Improve Feature Detect For oldIE bubbling. closes
gh-967"

This reverts commit 063ea02.

I've beaten on this for a while and can't find a suitable feature detect that catches Chrome's support for focusin.
d867d8b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Oct 15, 2012
  1. @fracmak

    Fixes #12569. Switches the check to run only if addEVentListener is u…

    fracmak authored
    …ndefined, not if we detect an IE only function
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  src/support.js
View
2  src/support.js
@@ -153,7 +153,7 @@ jQuery.support = (function() {
// are used, namely in IE. Short-circuiting here helps us to
// avoid an eval call (in setAttribute) which can cause CSP
// to go haywire. See: https://developer.mozilla.org/en/Security/CSP
- if ( div.attachEvent ) {
+ if ( !div.addEventListener ) {
for ( i in {
submit: true,
change: true,
Something went wrong with that request. Please try again.