Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

JSHint: standardize options inclusion, add node option to grunt.js, and remove unused vars in grunt.js #983

Closed
wants to merge 3 commits into from

2 participants

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Oct 16, 2012
  1. @mikesherov

    clean up jshintrc configs

    mikesherov authored
  2. @mikesherov

    remove unused vars

    mikesherov authored
  3. @mikesherov

    homogenize jshint options

    mikesherov authored
This page is out of date. Refresh to see the latest.
Showing with 31 additions and 36 deletions.
  1. +14 −10 .jshintrc
  2. +2 −11 grunt.js
  3. +7 −7 src/.jshintrc
  4. +8 −8 test/.jshintrc
View
24 .jshintrc
@@ -1,12 +1,16 @@
{
- "curly": true,
- "eqnull": true,
- "eqeqeq": true,
- "expr": true,
- "latedef": true,
- "noarg": true,
- "quotmark": "double",
- "smarttabs": true,
- "trailing": true,
- "undef": true
+ "options": {
+ "curly": true,
+ "eqeqeq": true,
+ "eqnull": true,
+ "expr": true,
+ "latedef": true,
+ "noarg": true,
+ "node": true,
+ "quotmark": "double",
+ "smarttabs": true,
+ "trailing": true,
+ "undef": true,
+ "unused": true
+ }
}
View
13 grunt.js
@@ -5,9 +5,6 @@
*
*/
-/*jshint node: true */
-/*global config:true, task:true, process:true*/
-
module.exports = function( grunt ) {
"use strict";
@@ -24,15 +21,10 @@ module.exports = function( grunt ) {
return data;
}
- var task = grunt.task;
var file = grunt.file;
- var utils = grunt.utils;
var log = grunt.log;
var verbose = grunt.verbose;
- var fail = grunt.fail;
- var option = grunt.option;
var config = grunt.config;
- var template = grunt.template;
var distpaths = [
"dist/jquery.js",
"dist/jquery.min.js"
@@ -99,7 +91,7 @@ module.exports = function( grunt ) {
}
return {
- options: jshintrc(),
+ grunt: jshintrc(),
dist: jshintrc( "src/" ),
tests: jshintrc( "test/" )
};
@@ -260,8 +252,7 @@ module.exports = function( grunt ) {
"Concatenate source (include/exclude modules with +/- flags), embed date/version",
function() {
// Concat specified files.
- var i,
- compiled = "",
+ var compiled = "",
modules = this.flags,
explicit = Object.keys(modules).length > 1,
optIn = !modules["*"],
View
14 src/.jshintrc
@@ -1,17 +1,17 @@
{
"options": {
- "evil": true,
"browser": true,
- "wsh": true,
+ "curly": true,
"eqnull": true,
+ "evil": true,
"expr": true,
- "curly": true,
- "trailing": true,
- "undef": true,
+ "maxerr": 100,
+ "quotmark": "double",
"smarttabs": true,
"sub": true,
- "maxerr": 100,
- "quotmark": "double"
+ "trailing": true,
+ "undef": true,
+ "wsh": true
},
"globals": {
"define": true,
View
16 test/.jshintrc
@@ -1,17 +1,18 @@
{
"options": {
- "evil": true,
"browser": true,
- "wsh": true,
+ "curly": true,
+ "devel": true,
"eqnull": true,
+ "evil": true,
"expr": true,
- "curly": true,
- "trailing": true,
- "undef": true,
- "smarttabs": true,
"maxerr": 100,
+ "quotmark": "double",
+ "smarttabs": true,
"sub": true,
- "quotmark": "double"
+ "trailing": true,
+ "undef": true,
+ "wsh": true
},
"globals": {
"define": true,
@@ -24,7 +25,6 @@
"require": true,
"file": true,
"log": true,
- "console": true,
"QUnit": true,
"ok": true,
"equal": true,
Something went wrong with that request. Please try again.