Rewrote queue article this resolves #77 #176

Closed
wants to merge 2 commits into from

7 participants

@bentonam

This article was dated and needed to be rewritten. I am interested to hear your thoughts on it.

@bobholt
jQuery Foundation member

I dig it.

Only comment is to make sure the code examples comply with jQuery Core Styles. I'm going through existing content to close #29, so we should make sure any new commits comply. (Double quotes, and some spacing issues were the things I saw here).

@rwaldron
jQuery Foundation member

@bobholt 👍

@ajpiano
jQuery Foundation member

@gnarf37 This PR is meant to address issue #77, which is to consolidate the old queue/dequeue article with your stackoverflow post, which is currently in the learn site archive as well. Can you give a quick review here and see if this achieves that end acceptably?

Also @bentonam, can you push a commit removing the "uses_of_queue_and_dequeue.md" (@gnarf's post) as well as the entry from order.yml? Thanks.

@addyosmani
jQuery Foundation member

If you could resolve the merge conflicts while this is being reworked that would also ease landing this. Thanks :)

@addyosmani
jQuery Foundation member

Ping @bentonam

@gnarf
jQuery Foundation member

( stealing this issue to test something - sorry! )

@gnarf gnarf closed this Nov 19, 2012
@gnarf gnarf reopened this Nov 19, 2012
@addyosmani
jQuery Foundation member

@bentonam @gnarf37

Do you think we could wrap up the work on this PR in the new year so we can bring it in? :)

@ajpiano
jQuery Foundation member

I still think this is an improvement over the existing article. Is there really anything else remaining here or do you think the branch just needs to be cleaned up so it can merge cleanly @gnarf37 ?

@gnarf
jQuery Foundation member
@ajpiano
jQuery Foundation member

If you can sign our CLA, I can clean this up and get it merged, @bentonam. Actually, @bobholt, if you could sign the CLA as well, we should have one on file for you as you've already got a bunch of commits on this repo too!

@eddiemonge

"If you can sign our CLA, I can clean this up and get it merged, @bentonam. Actually, @bobholt, if you could sign the CLA as well, we should have one on file for you as you've already got a bunch of commits on this repo too!"

@gnarf
jQuery Foundation member

We've asked for a CLA and can't merge without it. Going to close this for now. @bentonam i'd really like to take this change in, but it needs a rebase and someone to look over it again. If you're willing could you please sign the CLA and take a look at it again?

@gnarf gnarf closed this Dec 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment