Style fixes on the About page. #279

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

alimony commented Mar 1, 2013

  • Curly apostrophes and quotation marks.
  • Oxford commas.
  • Period after second bullet point sentence.
  • Mdashes instead of double-hyphens.
  • Fix typo: "who need the right away" -> "who need them right away".
Contributor

alimony commented Mar 1, 2013

Not entirely sure about the em dashes, the style guide doesn't mention dash usage, maybe it should? The Chicago Manual of Style says em dash without spaces around it, however I think em dash with spaces around it looks better :)

@alimony alimony Style fixes on the About page.
* Oxford commas.
* Period after second bullet point sentence.
* Em dashes instead of double-hyphens.
* Fix typo: "who need the right away" -> "who need them right away".
367f4a4
Member

ajpiano commented Mar 14, 2013

+1 em dash with spaces around it

ajpiano closed this in 7320dd6 Mar 14, 2013

@rmurphey rmurphey added a commit to rmurphey/learn.jquery.com that referenced this pull request Mar 17, 2013

@rmurphey rmurphey Merge branch 'master' into fix_method_refs
* master: (21 commits)
  0.2.7
  Remove remaining trailing whitespace from all pages. Fixes #313.
  Style and typography fixes, and code style adherence in the JavaScript 101 section. Fixes #312.
  0.2.6
  Correct comment in :input selector in Selecting Elements article. Fixes #306.
  Expand the JavaScript 101 'Scope' article with more useful information and explanations. Fixes #201.
  Added 0 to the list of falsy values in JavaScript 101 Conditional Code article. Fixes #300. Fixes #271
  Inserted missing word in the JavaScript 101 Arrays article. Fixes #299.
  Fixed inconsistency in showLinkLocation example in Basic Plugin Creation article. Fixes #307.
  Fix example and other style cleanup in Basic Plugin Creation article. Fixes #310. Fixes #311.
  Update list of reserved words in JavaScript. Fixes #301.
  Style and typography fixes and code style adherence in the Events section. Fixes #294.
  Style and typography fixes, and code style adherence in the Effects section. Fixes #290.
  Style and typography fixes, and code style adherence in the Code Organization section. Fixes #287.
  Remove double ampersands in README header. Fixes #284.
  Code and prose style improvements to all articles in Ajax chapter. Fixes #283.
  Style fixes on the About page. Fixes #279.
  Style guide fixes for the index, contributing, and About jQuery articles. Fixes #270
  relabel queue/dequeue content as advanced
  Added a missing 'i' in the for loop. Fixes #280.
  ...

Conflicts:
	page/ajax/ajax-and-forms.md
	page/ajax/jquery-ajax-methods.md
	page/effects/custom-effects.md
	page/effects/intro-to-effects.md
	page/events/event-basics.md
	page/events/event-helpers.md
	page/events/introduction-to-custom-events.md
	page/events/triggering-event-handlers.md
bac5e33

@arthurvr arthurvr pushed a commit to arthurvr/learn.jquery.com that referenced this pull request Jan 4, 2015

@alimony @ajpiano alimony + ajpiano Style fixes on the About page. Fixes #279.
* Oxford commas.
* Period after second bullet point sentence.
* Em dashes instead of double-hyphens.
* Fix typo: "who need the right away" -> "who need them right away".
64dbe16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment