Style fixes in the jQuery Mobile section. #329

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
4 participants
Contributor

alimony commented Apr 10, 2013

See commit messages for details.

alimony added some commits Apr 10, 2013

@alimony alimony Style fixes to the jQuery Mobile section.
Code changes:
* Spaces to tabs.
* Lower-case doctype tag.
* Always use self-closing HTML elements.
* Fix incorrect "/header" comment.
2c98db3
@alimony alimony Style fixes to the jQuery Mobile section.
Style fixes:
* Oxford commas.
* Title case headers.
* `<tagname>` instead of `tagname` for inline HTML code.
* A few word reshuffles for sentence clarity.
* Double instead of single quotes in body text.
* …various bits and pieces.
d5992f0
Contributor

alimony commented May 2, 2013

So, what's happening with these pull requests? It's been three weeks now :)

@eddiemonge eddiemonge commented on the diff May 16, 2013

page/jquery-mobile/getting-started.md
```
-<!DOCTYPE html>
+<!doctype html>
@eddiemonge

eddiemonge May 16, 2013

Contributor

why change this?

@alimony

alimony May 17, 2013

Contributor

I just followed the style used in the examples in the jQuery HTML style guide: http://contribute.jquery.org/style-guide/html/

@scottgonzalez

scottgonzalez May 17, 2013

Owner

Yes, lowercase tags is always correct.

@eddiemonge eddiemonge and 2 others commented on an outdated diff May 16, 2013

page/jquery-mobile/getting-started.md
- </div><!-- /header -->
-
- <div data-role="content">
- <p>Hello world</p>
- </div><!-- /content -->
-
- <div data-role="footer">
- <h4>My Footer</h4>
- </div><!-- /header -->
-
- </div><!-- /page -->
-
- </body>
+<head>
+ <title>My Page</title>
+ <meta name="viewport" content="width=device-width, initial-scale=1" />
@eddiemonge

eddiemonge May 16, 2013

Contributor

self-closing tags aren't necessary

@alimony

alimony May 17, 2013

Contributor

Should I change them back? In any case, adding this to the HTML style guide would be a good idea.

@scottgonzalez

scottgonzalez May 17, 2013

Owner

The self-closing elements are covered in the style guide. In the Elements and Attributes section it says "Self-closing elements should not be closed." The Encoding section and Example section both show a <meta> tag without the closing slash.

Contributor

alimony commented May 17, 2013

Fixed the self-closing (doh!) tags now.

ajpiano closed this in 96f6894 May 17, 2013

Member

ajpiano commented May 17, 2013

Thanks @alimony. I'm aiming to trim this backlog of PRs today and then connect with you about setting you up as a repo collaborator!!

Contributor

alimony commented May 21, 2013

@ajpiano Cool, seems like all of them are merged now. I still have a few pages to go through, having repo access when doing so could definitely keep the workload down for the rest of you. I could help out with some of the others' pull requests too. How do we set this up? And how should it work? Do I still open PRs based on feature branches, but merge them myself?

Thanks for spending some time with my pull requests :)

@arthurvr arthurvr pushed a commit to arthurvr/learn.jquery.com that referenced this pull request Jan 4, 2015

@alimony @ajpiano alimony + ajpiano Style fixes to the jQuery Mobile section. Fixes #329. 0791a54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment