Update optimize-selectors.md #430

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@AurelioDeRosa
Member

Added a paragraph about the use of the Not Equal Attribute Selector in older browsers

@AurelioDeRosa AurelioDeRosa Update optimize-selectors.md
Added a paragraph about the use of the Not Equal Attribute Selector in older browsers
d5f9c91
@ajpiano
Member
ajpiano commented Dec 19, 2013

Thanks. First of all, can you sign our CLA?

@scottgonzalez
Member

He has. He's been updating docs in various repos for a while now :-)

@ajpiano
Member
ajpiano commented Dec 19, 2013

I checked and it didn't come up in cmd-F for some silly reason, now I see it. Sorry bout

My thought about this PR is that it should be more general than just warning about attribute not equals - it should talk about being aware of using non-QSA selectors (e.g., attr not equal, :eq, :first, and so on), and talk about various replacements for each.

@AurelioDeRosa
Member

@ajpiano as @scottgonzalez I already signed the CLA.

About your comment, should I update the commit to include all the advices you suggested?

@ajpiano
Member
ajpiano commented Dec 20, 2013

You can just add further commits to the branch @AurelioDeRosa

@scottgonzalez
Member

Closing due to inactivity.

@AurelioDeRosa It'd be great if you could send a new PR with a broader scope.

@AurelioDeRosa AurelioDeRosa deleted the AurelioDeRosa:patch-1 branch Oct 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment