Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Fix test duration/runtime #395

Closed
jzaefferer opened this Issue · 3 comments

3 participants

@jzaefferer
Owner

Originally added in #344, but has some shortcomings. Should use "runtime" instead of "duration", to make it consistent with the property passed to the done callback.

Should also be provided for modules, not just tests.

See also de2353a#commitcomment-2414467

@JamesMGreene
Collaborator

Very much agreed! :+1:

@Krinkle
Collaborator

It seems like the duration test is subject to a race condition. setTimeout isn't reliable. We need to give it more slack/tolerance.

@jzaefferer jzaefferer closed this issue from a commit
@jzaefferer jzaefferer Logging: Add runtime property to testDone, deprecate duration
Will remove duration in 2.0.0, runtime does the same thing and is consistent
with the runtime property on the done callback.

Fixes #395
4eb4cfd
@jzaefferer jzaefferer closed this in 4eb4cfd
@jzaefferer
Owner

Added runtime, deprecating the duration property on testDone. Created #499 to add the runtime property for moduleDone and #500 to remove the duration property in 2.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.