Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Improve or drop phantomjs add-on #420

Closed
jzaefferer opened this Issue · 9 comments

4 participants

@jzaefferer
Owner

We should either remove the phantomjs addon and refer to other solutions like https://github.com/gruntjs/grunt-contrib-qunit or move the add-on to a standalone repository and work with for example the grunt guys to make this add-on useful to them, so that they can actually use it instead of maintaining their own integration. Even if that doesn't happen, it should at least replace the bundled example, which is really bad: https://github.com/ariya/phantomjs/blob/master/examples/run-qunit.js
Maybe we can just contribute the add-on to phantomjs and help them maintain that copy, instead of our own repo.

@JamesMGreene @Krinkle what do you think?

@JamesMGreene
Collaborator

I'd say contribute it to the PhantomJS example scripts, remove it from the QUnit repo, and then focus efforts on improving grunt-contrib-qunit instead.

@JamesMGreene
Collaborator

Well, unless you are confident we can make a standalone version of this useful to the Grunt folks....?

@cowboy @ctalkington @tkellen Thoughts?

@cowboy

If you have any interest in contributing to (or maintaining) the official grunt-contrib-qunit plugin and grunt-lib-phantomjs lib, we'd be very appreciative for the help!

Also, if you make a standalone version that can be back-ported into the Grunt plugin or the aforementioned lib, that would be great. What I wrote works pretty well, but I'm sure it could be improved upon.

@JamesMGreene JamesMGreene was assigned
@jzaefferer
Owner

There's certainly enough interest in this plugin (no more add-ons), so we'll keep it. Have still to figure out where and how it should live on. Not everyone uses grunt, but if the grunt plugin can use it, all the better.

We should also send a PR or something to eventually replace the thing bundled with PhantomJS.

@JamesMGreene
Collaborator

Regarding the PhantomJS-bundled "run-qunit.js" example: ariya/phantomjs#412 (comment)

cc: @ariya

@Krinkle Krinkle was assigned
@JamesMGreene
Collaborator

I reassigned this to @Krinkle for now as he is planning to take ownership of the PhantomJS plugin.

@JamesMGreene JamesMGreene was assigned
@jzaefferer
Owner

@JamesMGreene since Timo never create a repo for the plugin, would you be interested in taking that over? I really want to remove the code from this repo asap.

@jzaefferer jzaefferer closed this issue from a commit
@jzaefferer jzaefferer Addons: Remove last remnants
No immediate replacement available, yet. Feel free to take the deleted
code and host it in your own GitHub repo, we'll link to it on
http://qunitjs.com/plugins

Otherwise, use plugins like grunt-contrib-qunit to run QUnit tests in
PhantomJS.

Fixes gh-420
Ref gh-470
098221e
@jzaefferer
Owner

This is gone from master and won't be in 1.14 anymore. Anyone interested in this script is welcome to host it in a new repo.

@JamesMGreene
Collaborator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.