Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Gruntfile: Add QUnit.step test suite to qunit:addons config #360

Closed
wants to merge 1 commit into from

3 participants

@JamesMGreene
Collaborator

Added the QUnit.step test suite to the list of suites in the qunit:addons config in the Gruntfile. They were not being run with the grunt build before this.

@Krinkle
Collaborator

Tests need to pass first.

Testing step.htmlFF
>> reset - reset runs assertions
>> Message: reset should not modify test status
>> at jquery/qunit/qunit/qunit.js:480
>>   at jquery/qunit/test/test.js:713
>>   at jquery/qunit/qunit/qunit.js:301
>>   at jquery/qunit/qunit/qunit.js:325
>>   at process (jquery/qunit/qunit/qunit.js:1358)
>>   at jquery/qunit/qunit/qunit.js:425

>> Step Addon - step
>> Message: step starts at 1
>> Actual: NaN
>> Expected: 1
>> at jquery/qunit/addons/step/qunit-step.js:17
>>   at jquery/qunit/addons/step/step-test.js:4
>>   at jquery/qunit/qunit/qunit.js:161
>>   at jquery/qunit/qunit/qunit.js:319
>>   at process (jquery/qunit/qunit/qunit.js:1358)
>>   at jquery/qunit/qunit/qunit.js:425

>> Step Addon - step
>> Message: before the setTimeout callback is run
>> Actual: NaN
>> Expected: 2
>> at jquery/qunit/addons/step/qunit-step.js:17
>>   at jquery/qunit/addons/step/step-test.js:9
>>   at jquery/qunit/qunit/qunit.js:161
>>   at jquery/qunit/qunit/qunit.js:319
>>   at process (jquery/qunit/qunit/qunit.js:1358)
>>   at jquery/qunit/qunit/qunit.js:425

>> Step Addon - step
>> Message: step 3
>> Actual: NaN
>> Expected: 3
>> at jquery/qunit/addons/step/qunit-step.js:17
>>   at jquery/qunit/addons/step/step-test.js:7

>> Step Addon - step counter
>> Message: each test has its own step counter
>> Actual: NaN
>> Expected: 1
>> at jquery/qunit/addons/step/qunit-step.js:17
>>   at jquery/qunit/addons/step/step-test.js:14
>>   at jquery/qunit/qunit/qunit.js:161
>>   at jquery/qunit/qunit/qunit.js:319
>>   at process (jquery/qunit/qunit/qunit.js:1358)
>>   at jquery/qunit/qunit/qunit.js:425

<WARN> 4/579 assertions failed (3426ms) Use --force to continue. </WARN>
@JamesMGreene
Collaborator

What's your system configuration? They passed for me on Win7 Chrome (latest stable).

Also, your results would suggest that these same tests passed when executed as part of the composite suite, which is already running with Grunt.
https://github.com/jquery/qunit/blob/master/addons/composite/composite-demo-test.html

@Krinkle
Collaborator

I ran them from grunt (like your commit configures), which uses phantomjs. I just ran plain "grunt" after applying this PR locally.

I tried Ubuntu (which we use on the CI server) and Mac OS X (my local environment).

@JamesMGreene
Collaborator

What version of PhantomJS is in your path?

@Krinkle
Collaborator

PhantomJS 1.7.0, managed by Homebrew.

@JamesMGreene
Collaborator

And do the step tests pass for you when executed as part of the composite addon's test suite?

@Krinkle
Collaborator

Naturally yes, it runs before this one and there were no errors reported.

@JamesMGreene
Collaborator

Fantastic. :stuck_out_tongue:

Have any of the other contributors run into this problem or has it only been seen on your box(es) to date?

@Krinkle
Collaborator

It fails on the CI server as well. That's why it was removed from the grunt job.

So you're saying that executing plain grunt works for you?

@JamesMGreene
Collaborator

Well, sort of... but not really. I have to do grunt --force because, for me, the "canvas" and "close-enough" tests timeout but the "composite" and "step" tests pass... and yet, the "composite" suite runs both the "canvas" and "close-enough" test suites successfully. :expressionless:

image

@jzaefferer
Owner

I just tried this and tests passed just fine for me. No timeouts either. OSX with Phantomjs 1.7.0.

@JamesMGreene
Collaborator

Sooo... that's fun. Next steps to resolution?

@jzaefferer
Owner

Well, I've enabled both suites that were disabled and they pass just fine. Commited in b339e72

@jzaefferer jzaefferer closed this
@jzaefferer jzaefferer was assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 1 deletion.
  1. +2 −1  grunt.js
View
3  grunt.js
@@ -11,7 +11,8 @@ grunt.initConfig({
addons: [
'addons/canvas/canvas.html',
'addons/close-enough/close-enough.html',
- 'addons/composite/composite-demo-test.html'
+ 'addons/composite/composite-demo-test.html',
+ 'addons/step/step.html'
],
async: 'test/async.html'
},
Something went wrong with that request. Please try again.