Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

code around ie issues for location #384

Closed
wants to merge 1 commit into from

2 participants

@clog

Assigning incomplete url won't work for local files in ie7 and ie8. Means controls won't work when test page is opened locally.

@clog clog code around ie issues for location
controls won't work in ie7, ie8
f927ced
@clog clog commented on the diff
qunit/qunit.js
@@ -962,7 +962,8 @@ extend( QUnit, {
querystring += encodeURIComponent( key ) + "=" +
encodeURIComponent( params[ key ] ) + "&";
}
- return window.location.pathname + querystring.slice( 0, -1 );
+ return window.location.protocol + "//" + window.location.host +
@clog
clog added a note

Sorry James M. Greene,

I didn't know force update removes comments associated with code segment. The
following is your original comment.

"That should definitely be window.location.host instead of
window.location.hostname. Also, I'm not sure if this works when using the
triple-slash short-form for File URIs on the localhost (i.e.
file://localhost/blah is equivalent to file:///blah) as I don't recall offhand
what the Location object will return for these properties when using the File
URI scheme...."

I just replaced hostname with host, you are right. :)

On the tripple-slash issue, I tried file:///* on Chrome, Firefox, IE7 and IE8.
They all work. I think it working. Maybe I don't understand your question?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@jzaefferer
Owner

Thanks, landed in 8676feb

@jzaefferer jzaefferer closed this
@jzaefferer jzaefferer was assigned
@leobalter leobalter referenced this pull request from a commit in leobalter/qunit
@gauravmittal1995 gauravmittal1995 HTML Reporter: New diff using Google's Diff-Patch-Match Library
Fixes #384
Closes #772
463fd39
@leobalter leobalter referenced this pull request from a commit in leobalter/qunit
@gauravmittal1995 gauravmittal1995 HTML Reporter: New diff using Google's Diff-Patch-Match Library
Fixes #384
Closes #772
40157ba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Dec 26, 2012
  1. @clog

    code around ie issues for location

    clog authored
    controls won't work in ie7, ie8
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 1 deletion.
  1. +2 −1  qunit/qunit.js
View
3  qunit/qunit.js
@@ -962,7 +962,8 @@ extend( QUnit, {
querystring += encodeURIComponent( key ) + "=" +
encodeURIComponent( params[ key ] ) + "&";
}
- return window.location.pathname + querystring.slice( 0, -1 );
+ return window.location.protocol + "//" + window.location.host +
@clog
clog added a note

Sorry James M. Greene,

I didn't know force update removes comments associated with code segment. The
following is your original comment.

"That should definitely be window.location.host instead of
window.location.hostname. Also, I'm not sure if this works when using the
triple-slash short-form for File URIs on the localhost (i.e.
file://localhost/blah is equivalent to file:///blah) as I don't recall offhand
what the Location object will return for these properties when using the File
URI scheme...."

I just replaced hostname with host, you are right. :)

On the tripple-slash issue, I tried file:///* on Chrome, Firefox, IE7 and IE8.
They all work. I think it working. Maybe I don't understand your question?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
+ window.location.pathname + querystring.slice( 0, -1 );
},
extend: extend,
Something went wrong with that request. Please try again.