New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc: Update isXML to recognize HTML-embedded elements #436

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@gibson042
Copy link
Member

gibson042 commented Dec 3, 2018

Fixes gh-378

@mgol

mgol approved these changes Dec 3, 2018

@@ -559,10 +560,13 @@ support = Sizzle.support = {};
* @returns {Boolean} True iff elem is a non-HTML XML node

This comment has been minimized.

@timmywil

timmywil Dec 4, 2018

Member

Maybe we could go ahead and fix this typo, iff you want.

This comment has been minimized.

@gibson042

gibson042 Dec 4, 2018

Member

What typo? Do you think we should replace "iff" with "if and only if"?

This comment has been minimized.

@timmywil

timmywil Dec 4, 2018

Member

I didn't know that's what it meant. It's been a long time since I did proofs. I remember using "↔" but not "iff".

This comment has been minimized.

@mgol

mgol Jan 14, 2019

Member

BTW, while I've used this notation repeatedly I'd guess it's not common knowledge among programmers without theoretical background. Expanding that could increase intelligibility of the comment to the general public.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment