Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Job status and tinder should not assume first row is equal to others #13

Closed
Xorath opened this Issue Sep 19, 2009 · 4 comments

Comments

Projects
None yet
4 participants

Xorath commented Sep 19, 2009

When running testswarm and only having one test-module the browser icons does not appear above the results-table. Adding an empty dummy-module makes them appear.

tmyoung commented Nov 17, 2009

I have the same problem.

bachp added a commit to siemens/testswarm that referenced this issue Jun 1, 2011

Fix no icons rendering in jobstatus and on user page. This fixes Issue
…#13.

It's based on a patch from parente (Peter Parente).

bachp added a commit to siemens/testswarm that referenced this issue Jun 27, 2011

Fix no icons rendering in jobstatus and on user page. This fixes Issue
…#13.

It's based on a patch from parente (Peter Parente).
Member

Krinkle commented Aug 9, 2011

There's a bunch of other problems with the current output mechanism.

The biggest problem is that it echo'es right away and assumes the first row is the same as all other rows. Meaning when account X submits a job for browser A B and C, then then another job for C, D E and F. Then the latter job will be good, but all earlier job statuses will show up in the wrong column, or even missing if there's fewer columns.

This can be fixed by writing the output to a an array, and during the loop keep track of all browsers encountered. Then at the end all browsers are known and the headers can be outputted. Then you loop over the array and when there's a key missing you output an empty table cell with class "notsubmitted".

An example can be seen at http://toolserver.org/~krinkle/testswarm/user/KrinkleBot
There you can see that from job "MediaWiki Commit r88224" onwards Opera 11.1 was added to the mix. Jobs before that would, if toolserver ran current master HEAD, go messed up and put them in the wrong column. Instead there are extra table cells outputted to account for the differences.

Proposal: http://jquerytesting.pbworks.com/w/page/44121636/TestSwarm-OOP

Owner

jzaefferer commented Oct 10, 2011

Fixed by #73 - even if it doesn't address all the problems that @Krinkle outlined, those we need to put into a separate issue.

Member

Krinkle commented Oct 24, 2011

Since jQuery's swarm install got reset I can't test this bug properly. We need to confirm fix and then we can close this bug.

@Krinkle Krinkle closed this in ca6abd4 Mar 31, 2012

mikehostetler pushed a commit to appendto/testswarm that referenced this issue May 8, 2012

[issue #143] Convert UserPage to new user agent system + Implement Fa…
…uxRequestContext

- Extracted the logic into UserAction (issue #132)

- Dropped support for the ?job= parameter that functioned as a primitive
  search filter for certain job names, but was kinda useless since
  it stripped out characters commonly found in job names (such as numbers
  and full-stops) and even then, job names are sorted by creation,
  and then mysql_queryf escapes some parts.

  Could be easily (re)implemented "the right way" over in the UserAction.
  Anyone interested may create an issue for it.

- Converted BrowserInfo::getBrowscap() into an array with a known set of
  properties instead of blindly passing the original object which has many
  other properties that should not be used.

- DerivativeWebRequest, Context::createDerivedRequestContext
 * New class that takes query parameters and POST boolean
   and creates a fake Context object derived from the given
   context object. Used to use JobAction inside UserAction.

- Fixed #13 (again). This made it visible that status-new should be grey
  and status-notscheduled white (which is how it was before twitter bootstrap)

- Added json_decode/json_encode normalization to Action::setData.
  This way all Action responses contain associative arrays and never
  objects.

- Poke #137, using <div class="alert alert-error"> for error messages.

maciejblinkbox referenced this issue in maciejblinkbox/testswarm Aug 21, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment