TestSwarm doesn't play nicely with QUnit.Composite #264

Closed
dcherman opened this Issue Mar 21, 2013 · 0 comments

Comments

Projects
None yet
1 participant
Contributor

dcherman commented Mar 21, 2013

I think the problem is that in Testswarm's inject.js, QUnit.done is being overridden to submit results. In QUnit Composite, calling QUnit.testSuites invokes the following:

QUnit.done(function() {
   iframe.style.display = "none";
});

which seems to be causing TestSwarm to think the suite has been run when not a single test has been executed at that point. If I comment out that call, things seem to work better.

I wasn't really sure which repo to file this under, but it seems like it's a TestSwarm bug since it's modifying the expected behavior of what QUnit.done should be doing according to the API docs

@dcherman dcherman added a commit to dcherman/testswarm that referenced this issue Mar 21, 2013

@dcherman dcherman Don't override QUnit.done - fixes gh-264
Rather than overriding QUnit.done, register a callback with it so that
it continues to function normally.  Overriding it was causing the
behavior of QUnit.done to differ from what was specified in the API docs
which caused some weird behavior with other plugins like QUnit.Composite
7658297

Krinkle closed this in fed8b59 Mar 21, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment